Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgoCD doesn't support helm k8s lookup and thus qdrant existing secret lookup fails #249

Open
pschwager opened this issue Sep 30, 2024 · 2 comments

Comments

@pschwager
Copy link

I just tried your latest changes with a ArgoCD deployment, by specifing a apiKeys via an existing secret like

apiKey:
  valueFrom:
     secretKeyRef:
       name: "secretname"
       key: "apikeyname"

This doesn't work, as ArgoCD doesn't support the helm lookup function:
argoproj/argo-cd#5202

During debugging the issue I found out, that the qdrant helm chart tries to read the existing k8s secret and creates a new secret.

I'm looking for some alternative solution to specify the api keys outside the qdrant helm chart, so that I don't have to put the secerts as cleartext into our deployment repos... any suggestion?

@justbert
Copy link

Also hitting this. I think, instead of having the the template lookup the secret and copy it to a new secret, the secret could just be mounted. It needs to reside in the same namespace anyway.

@joseprsm
Copy link

joseprsm commented Nov 27, 2024

Also facing this issue. I still haven't tested it but my current workaround is to pass these values to the environment variables of the StatefulSet.

  env:
    - name: QDRANT__SERVICE__API_KEY
      valueFrom:
        secretKeyRef:
          name: "secretname"
          key: "apikeyname"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants