Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with the new Qibo global backend handling #1022

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alecandido
Copy link
Member

@alecandido alecandido commented Oct 23, 2024

qiboteam/qibo#1440 (comment)

Qibocal is not directly broken, until the next Qibo release.

Still, we want to have a strategy ready for when this release will happen (soon), and it will break Qibolab itself.
Qibo has no well-defined public API, and so this breaking change will happen in a minor version - thus leading to breakage if installed with the latest release.

In any case, all Qibolab users are invited to keep using Qibo v0.2.12 until the next Qibocal release, if they use a release. Otherwise, hopefully this will be soon ready to be merged in https://github.com/qiboteam/qibocal/tree/main

@alecandido
Copy link
Member Author

@igres26, if you already tested and got an error, try to take a look at this branch, and please if there is any further error being raised.

I'm also scanning and checking other possible usages that are prone to fail because of qiboteam/qibo#1440.
I will even properly test later on, but for the time being, it was just a quick fix in case someone needs to use Qibocal's and Qibolab's development versions (which I hope no one is doing, but I don't know).

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.51%. Comparing base (5ff3d90) to head (6919e9f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1022   +/-   ##
=======================================
  Coverage   97.50%   97.51%           
=======================================
  Files         124      124           
  Lines        9833     9831    -2     
=======================================
- Hits         9588     9587    -1     
+ Misses        245      244    -1     
Flag Coverage Δ
unittests 97.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...qibocal/protocols/randomized_benchmarking/utils.py 95.78% <100.00%> (-0.02%) ⬇️
src/qibocal/protocols/readout_mitigation_matrix.py 100.00% <100.00%> (ø)
src/qibocal/protocols/state_tomography.py 98.65% <100.00%> (ø)
...l/protocols/two_qubit_interaction/chsh/protocol.py 97.66% <100.00%> (ø)
...rc/qibocal/protocols/two_qubit_state_tomography.py 99.29% <100.00%> (ø)

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant