Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flux-Drive timing #1056

Draft
wants to merge 5 commits into
base: 0.2
Choose a base branch
from
Draft

Flux-Drive timing #1056

wants to merge 5 commits into from

Conversation

Edoardo-Pedicillo
Copy link
Contributor

@Edoardo-Pedicillo Edoardo-Pedicillo commented Dec 9, 2024

This PR implements the protocol XY-Z timing (https://escholarship.org/content/qt0g29b4p0/qt0g29b4p0.pdf?t=prk0gj par. 5.10).

http://login.qrccluster.com:9000/xWr3LZnfTQmN59r2aFetnA==/

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 36.19048% with 67 lines in your changes missing coverage. Please review.

Project coverage is 96.22%. Comparing base (c280398) to head (8d6e59c).
Report is 4 commits behind head on 0.2.

Files with missing lines Patch % Lines
src/qibocal/protocols/xyz_timing.py 35.57% 67 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              0.2    #1056      +/-   ##
==========================================
- Coverage   97.02%   96.22%   -0.80%     
==========================================
  Files          98       99       +1     
  Lines        7893     7998     +105     
==========================================
+ Hits         7658     7696      +38     
- Misses        235      302      +67     
Flag Coverage Δ
unittests 96.22% <36.19%> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/qibocal/protocols/__init__.py 100.00% <100.00%> (ø)
src/qibocal/protocols/xyz_timing.py 35.57% <35.57%> (ø)

@Edoardo-Pedicillo Edoardo-Pedicillo marked this pull request as draft December 9, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant