Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign some driver commons #1089

Open
alecandido opened this issue Nov 1, 2024 · 1 comment
Open

Redesign some driver commons #1089

alecandido opened this issue Nov 1, 2024 · 1 comment
Labels
Milestone

Comments

@alecandido
Copy link
Member

alecandido commented Nov 1, 2024

The common Instrument and Controller interfaces are pretty restricted, but there are at least a couple of elements that should be redesigned, namely

  • bounds
  • sampling_rate

There may be others (e.g. giving a clear role to setup()), but at least these should be rethought, especially taking into account #918.

The main motivation is that these attributes were designed assuming a monolithic controller, which is supposed to have a single set of memories, and a single acquisition/synthesis rate.
However, even the clustered devices that we have are modular, and they may require a different processing, broke down per-module.

Actually, #918 was thought for an even more general setup, where we could not even rely on a single driver for the synchronization (thus requiring a separate trigger handling).
But this is already extremely close to the modular setups we have, that separating the instructions upload and triggering may already be beneficial for the present drivers.

@alecandido alecandido added this to the Qibolab 0.3.0 milestone Nov 1, 2024
@alecandido
Copy link
Member Author

@stavros11 any opinion about?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant