Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to validate after every edit #8

Open
jairideout opened this issue Sep 6, 2014 · 1 comment
Open

add option to validate after every edit #8

jairideout opened this issue Sep 6, 2014 · 1 comment
Labels
enhancement

Comments

@jairideout
Copy link
Member

jairideout commented Sep 6, 2014 •
edited by Mestabrook3
Loading

Current Behavior
Right now validation is performed manually via a menu item.
jairideout added a commit that referenced this issue Dec 30, 2015
@jairideout
MAINT: refactor to separate model and view logic
7e13d9a 
Validators no longer take state as input and instead return info about invalid cells. Results from validators are combined to form the model, which can be rendered by views. There is currently only one view (SheetView) for rendering validation results in the Google Sheet itself (i.e., coloring cells and using notes to display validation messages).

This new factoring was necessary for #7 and #8. There are also minor performance gains due to fewer API calls (mainly because validators accept a value->positions mapping instead of recomputing in each validator).

Fixes #26.
@jairideout
Copy link
Member Author

This is now possible after the refactoring in 7e13d9a (and should be pretty easy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jairideout