Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

barplot/collapse: ignore trailing semicolon in annotations #79

Open
jairideout opened this issue Jul 7, 2017 · 0 comments
Open

barplot/collapse: ignore trailing semicolon in annotations #79

jairideout opened this issue Jul 7, 2017 · 0 comments
Labels
type:bug Something is wrong.

Comments

@jairideout
Copy link
Member

jairideout commented Jul 7, 2017

Bug Description
Some reference databases (e.g. PR2) include a trailing semicolon in their taxonomic annotations. barplot parses this trailing semicolon as an extra "empty" taxonomic level.

Expected Behavior
It'd be great to ignore trailing semicolons to avoid creating an empty level in the plots.

Comments
NOTE: I haven't tested what collapse does with trailing semicolons. Whoever is tackling this issue, please also test collapse -- we'd want to avoid collapsing at this trailing "empty" level (raising an error in this case sounds reasonable).

References
Came up on the forum here.

@jairideout jairideout changed the title barplot: ignore trailing semicolon in annotations barplot/collapse: ignore trailing semicolon in annotations Jul 7, 2017
@jairideout jairideout added the type:bug Something is wrong. label Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something is wrong.
Projects
None yet
Development

No branches or pull requests

1 participant