Regression in 4.5.1: Global namespace type declarations are removed

[roman-petrov]

Use case

We provide Jest custom matchers with our package and provide TypeScript type definitions too. As I know the only way to extend Jest matchers is to extend global jest namespace like this:

declare global {
  namespace jest {
    interface Matchers<R> {
      toChildSnapshot: (filename: string, name: string) => R;
    }
  }
}

This approach is officially documented in Jest documentation:

The problem

Before 4.5.1 release the plugin included such declarations in generated declaration code "as is", after 4.5.1 release these declarations just dropped.

Not sure, but this commit in 4.5.1 release might be the source of this problem.

I am not familiar with StackBlitz and it's a bit hard for me to create a complete reproduction link for this. I think the reproduction should be quite easy, just include the code above into any TypeScript flle.

Reproduction

n/a

Steps to reproduce

No response

System Info

n/a

Validations

• Read the FAQ.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• The provided reproduction is a minimal reproducible example of the bug.

[fengelniederhammer]

I saw the same issue. Downgrading to 4.5.0 "solved" it: GenSpectrum/dashboard-components#828

It would be great if you could make sure that global namespace declarations make it the .d.ts files again!

[RWhitelockForbesAdvisor]

Same here, I too have had to pin to 4.50

[qmhc]

Would you try to use the latest version(4.5.3) current?

[roman-petrov]

@qmhc I just tested four package versions with these global namespace types:

• 4.5.0 - everything is ok
• 4.5.1 - regression, drops global namespace types
• 4.5.2 - regression not fixed
• 4.5.3 - regression not fixed

So, as I noted in issue description, the regression happened in v.4.5.1 and it is still there.