Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from Vendoring of Meltano EDK #16

Open
joshua-janicas opened this issue Jan 6, 2025 · 1 comment
Open

Migrate away from Vendoring of Meltano EDK #16

joshua-janicas opened this issue Jan 6, 2025 · 1 comment

Comments

@joshua-janicas
Copy link
Contributor

joshua-janicas commented Jan 6, 2025

I was wondering if there is a good reason why dagster-ext is vendoring Meltano's EDK (https://github.com/quantile-development/dagster-ext/blob/master/meltano/edk/) rather than pinning a particular version from https://github.com/meltano/edk. With dagster-ext V0.1.2 to upgrade Pydantic (to allow later versions of 1.9 Dagster), it seems that was crashing on the annotations of missing :str on the description fields, which the Meltano EDK had already fixed.

image

For the purpose of future proofing the repo, I think we should be using Meltano's EDK as a package instead of including it directly in the folder structure.

@JulesHuisman
Copy link
Collaborator

Ah yes, the dagster-ext was build before the edk package existed / was stable. But this will need to be migrated to the pypi package in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants