-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set dagster version? #42
Comments
The version is set here: dagster-meltano/pyproject.toml Line 14 in f4410d2
But you can simply install a specific Dagster version in the same environment. E.g. |
Thanks for the suggestion.
This gives me the versions I posted before. Trying to upgrade with your suggestion is:
But during install, this result in conflicts: |
If you are able to dig up which packages are conflicting we can increase the range of those packages. |
Thanks @JulesHuisman I've been trying to set the dagster-ex to have dagster at least 1.5.0. So far no luck, I'll updater if I find the conflict. |
@JulesHuisman I think it has something to do with typer? I have been trying to use some kind of later version of Dagster 1.5 and I get the following logs Which I think is set here: https://github.com/quantile-development/dagster-ext/blob/master/pyproject.toml and we need to update Logs
|
I think we can probably increase the range of the package even more. I don't have too much time right now to look into it. But I might be able to look at it later, or possibly accept a PR. |
Hi @JulesHuisman , I did the following;
This is admittedly my first time trying to contribute to public repos, and I don't normally work in Python. I tried pushing my branches to the repos but I'm getting 403 errors because write access is restricted (reasonably so). If the above looks ok would I be give write access to both dagster-ext and dagster-meltano to push my changes so you could accept a PR? This would also help with #48 I think. Thank you! |
You can create a fork on Github, and then create a PR to the original repo! That way I can review the changes there. |
Hi Jules, Please see the PRs here, thanks! |
Thanks @joshua-janicas would be great to see this merged. I'd like to make use of some recent features in dagster-dbt with this change in place. |
Giving another poke here to see if we can have the PRs looked at sometime soon! Thank you! |
Deployed the new version, thanks @joshua-janicas! |
Does anyone know where the dagster version is set? I am not sure, but it seems dagster is installed via this package.
The versions are:
can we upgrade, or am i in the wrong place?
edit//
Or maybe it is here instead? https://github.com/quantile-development/dagster-ext
The text was updated successfully, but these errors were encountered: