From 97da5cc365df00fdc8cf0655492d14889f6b27c1 Mon Sep 17 00:00:00 2001
From: BernardWez <bernard.wezeman@quantile.nl>
Date: Mon, 20 Nov 2023 20:11:23 +0100
Subject: [PATCH] Add tests for tap with incremental stream (mocked)

---
 tests/conftest.py              |  2 +-
 tests/fixtures/tap.py          | 12 +++++
 tests/test_elx/test_catalog.py | 96 ++++++++++++++++++++++++++++++++++
 3 files changed, 109 insertions(+), 1 deletion(-)

diff --git a/tests/conftest.py b/tests/conftest.py
index 746ec38..067a7c7 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -1,5 +1,5 @@
 from fixtures.singer import singer
-from fixtures.tap import tap
+from fixtures.tap import tap, tap_incremental
 from fixtures.target import target
 from fixtures.runner import runner
 from fixtures.state import state_manager
diff --git a/tests/fixtures/tap.py b/tests/fixtures/tap.py
index c16b870..5780457 100644
--- a/tests/fixtures/tap.py
+++ b/tests/fixtures/tap.py
@@ -20,3 +20,15 @@ def tap() -> Generator[Tap, None, None]:
             ],
         },
     )
+
+
+@pytest.fixture(scope="session")
+def tap_incremental() -> Generator[Tap, None, None]:
+    """
+    Return a Tap instance for the  executable with an incremental stream.
+    """
+    yield Tap(
+        executable="tap-mock-incremental",
+        spec="git+https://github.com/quantile-taps/tap-mock-incremental.git",
+        config={},
+    )
diff --git a/tests/test_elx/test_catalog.py b/tests/test_elx/test_catalog.py
index b5f2d1c..05d960f 100644
--- a/tests/test_elx/test_catalog.py
+++ b/tests/test_elx/test_catalog.py
@@ -7,6 +7,7 @@
         {
             "tap_stream_id": "animals",
             "replication_method": "FULL_TABLE",
+            "replication_key": None,
             "table_name": None,
             "is_view": False,
             "key_properties": [],
@@ -56,6 +57,54 @@
     ]
 }
 
+INCREMENTAL_CATALOG = {
+    "streams": [
+        {
+            "tap_stream_id": "users",
+            "replication_method": "INCREMENTAL",
+            "replication_key": "updated_at",
+            "table_name": None,
+            "is_view": False,
+            "key_properties": ["id"],
+            "schema": {
+                "properties": {
+                    "id": {"type": ["string", "null"]},
+                    "name": {"type": ["string", "null"]},
+                    "updated_at": {
+                        "format": "date-time",
+                        "type": ["string", "null"],
+                    },
+                },
+                "type": "object",
+            },
+            "metadata": [
+                {
+                    "breadcrumb": ["properties", "id"],
+                    "metadata": {"inclusion": "automatic"},
+                },
+                {
+                    "breadcrumb": ["properties", "name"],
+                    "metadata": {"inclusion": "available"},
+                },
+                {
+                    "breadcrumb": ["properties", "updated_at"],
+                    "metadata": {"inclusion": "automatic"},
+                },
+                {
+                    "breadcrumb": [],
+                    "metadata": {
+                        "inclusion": "available",
+                        "selected": True,
+                        "selected-by-default": True,
+                        "table-key-properties": ["id"],
+                        "valid-replication-keys": ["updated_at"],
+                    },
+                },
+            ],
+        }
+    ]
+}
+
 
 def test_catalog(tap: Tap):
     """
@@ -103,3 +152,50 @@ def test_catalog_deselect_property(tap: Tap):
     catalog_dict = catalog.dict(by_alias=True)
 
     assert catalog_dict["streams"][0]["metadata"][0]["metadata"]["selected"] == False
+
+
+def test_catalog_replication_method(tap_incremental: Tap):
+    """If we have an incremental stream, the replication_method in the catalog should be `INCREMENTAL`."""
+    catalog_dict = tap_incremental.catalog.dict(by_alias=True)
+
+    replication_method = INCREMENTAL_CATALOG["streams"][0]["replication_method"]
+    assert replication_method == "INCREMENTAL"
+    assert catalog_dict["streams"][0]["replication_method"] == "INCREMENTAL"
+
+
+def test_catalog_replication_key(tap_incremental: Tap):
+    """If we have an incremental stream, the catalog should have a `replication_key`."""
+    catalog_dict = tap_incremental.catalog.dict(by_alias=True)
+
+    replication_key = INCREMENTAL_CATALOG["streams"][0]["replication_key"]
+    assert replication_key == "updated_at"
+    assert catalog_dict["streams"][0]["replication_key"] == replication_key
+
+
+def test_catalog_valid_replication_keys(tap_incremental: Tap):
+    """
+    If we have an incremental stream, the catalog should have a metadata breadcrumb for the incremental
+    stream containing the key: `valid-replication-keys`.
+
+    This key should be associated with a list containing the fields that could be used as replication keys.
+    For example, the metadata breadcrumb of the stream should look as follows if `updated_at` is its replication_key.
+
+    "metadata": {
+        "inclusion": "available",
+        "selected": True,
+        "selected-by-default": True,
+        "table-key-properties": ["id"],
+        "valid-replication-keys": ["updated_at"],
+    }
+    """
+    catalog_dict = tap_incremental.catalog.dict(by_alias=True)
+
+    replication_keys = catalog_dict["streams"][0]["metadata"][-1]["metadata"].get(
+        "valid-replication-keys", None
+    )
+
+    # Checks that the `valid-replication-keys` key exists
+    assert replication_keys != None
+
+    # Checks that value of `valid-replication-keys` equals to the replication-key
+    assert replication_keys == ["updated_at"]