Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarkus-maven-plugin:update doesn't propagate property #46168

Open
llowinge opened this issue Feb 10, 2025 · 1 comment
Open

quarkus-maven-plugin:update doesn't propagate property #46168

llowinge opened this issue Feb 10, 2025 · 1 comment
Labels
area/maven kind/enhancement New feature or request

Comments

@llowinge
Copy link
Contributor

Describe the bug

I'm having issue with situation, where i have custom Maven settings (provided with -s <custom-settings>) in combination with system property (-D<repository-name>) which enables specific repository (eg. specific repository where i want the update take artifacts from) from the <custom-settings>. I can see that system properties are not propagated at https://github.com/quarkusio/quarkus/blob/main/independent-projects/tools/devtools-common/src/main/java/io/quarkus/devtools/project/update/rewrite/QuarkusUpdateCommand.java#L159

For example my code needs atlassian repo to be buildable

        <profile>
            <id>repo.atlassian-public</id>
            <activation>
                <activeByDefault>false</activeByDefault>
                <property>
                    <name>repo.atlassian-public</name>
                </property>
            </activation>
            <repositories>
                <repository>
                    <id>atlassian-public</id>
                    <name>Atlassian Public</name>
                    <url>https://packages.atlassian.com/maven-external/</url>
                    <snapshots>
                        <enabled>true</enabled>
                    </snapshots>
                    <releases>
                        <enabled>true</enabled>
                    </releases>
                </repository>
            </repositories>
            <pluginRepositories>
                <pluginRepository>
                    <id>atlassian-public</id>
                    <name>Atlassian Public</name>
                    <url>https://packages.atlassian.com/maven-external/</url>
                </pluginRepository>
            </pluginRepositories>
        </profile>

set in custom-settings.xml

and then using -Drepo.atlassian-public i could enable it.

In this example, the system property -Drepo.atlassian-public is not propagated (but i guess any -D<property> is not propagated).

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@llowinge llowinge added the kind/bug Something isn't working label Feb 10, 2025
Copy link

quarkus-bot bot commented Feb 10, 2025

/cc @quarkusio/devtools (maven)

@gsmet gsmet added kind/enhancement New feature or request and removed kind/bug Something isn't working labels Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maven kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants