migrations: add missing index creating migration

While the sql command was added to claircore (and the admin command was
added to clairctl) to create an index it was never actually reference in
the migrations. This should be a no-op for all instances that ran the
associated clairctl admin command. Also, added a test to try and avoid
this in the future.

Signed-off-by: crozzy <[email protected]>

Author: crozzy

datastore/postgres/migrations/migrations.go

@@ -57,6 +57,10 @@ var IndexerMigrations = []migrate.Migration{
 		ID: 7,
 		Up: runFile("indexer/07-index-manifest_index.sql"),
 	},
+	{
+		ID: 8,
+		Up: runFile("indexer/08-index-manifest_layer.sql"),
+	},
 }
 
 var MatcherMigrations = []migrate.Migration{

datastore/postgres/migrations/migrations_test.go

@@ -0,0 +1,67 @@
+package migrations
+
+import (
+	"bufio"
+	iofs "io/fs"
+	"os"
+	"path"
+	"regexp"
+	"sort"
+	"testing"
+
+	"github.com/google/go-cmp/cmp"
+)
+
+func TestMigrationsMismatch(t *testing.T) {
+	var migrations, files []string
+
+	// Get referenced migrations
+	migrationLine, err := regexp.Compile(`runFile\(\"(.*)\"\)`)
+	if err != nil {
+		t.Fatal(err)
+	}
+	f, err := os.Open("migrations.go")
+	if err != nil {
+		t.Fatal(err)
+	}
+	defer f.Close()
+
+	s := bufio.NewScanner(f)
+	for s.Scan() {
+		ms := migrationLine.FindSubmatch(s.Bytes())
+		switch {
+		case ms == nil, len(ms) == 1:
+			continue
+		case len(ms) == 2:
+			migrations = append(migrations, path.Clean(string(ms[1])))
+		}
+	}
+	if err := s.Err(); err != nil {
+		t.Error(err)
+	}
+	sort.Strings(migrations)
+
+	// Get migration files
+	err = iofs.WalkDir(os.DirFS("."), ".", func(p string, d iofs.DirEntry, err error) error {
+		switch {
+		case err != nil:
+			return err
+		case d.IsDir():
+			return nil
+		case path.Ext(d.Name()) != ".sql":
+			return nil
+		}
+		files = append(files, p)
+		return nil
+	})
+	if err != nil {
+		t.Error(err)
+	}
+	sort.Strings(files)
+
+	// Check referenced files exist and existing files are referenced.
+	if !cmp.Equal(migrations, files) {
+		t.Log("error mismatch of migrations to entries:")
+		t.Error(cmp.Diff(migrations, files))
+	}
+}