Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CronJobs detection fail silently in 1.12.0 #1089

Closed
mr47 opened this issue Nov 3, 2022 · 7 comments · Fixed by #1091 or #1092
Closed

CronJobs detection fail silently in 1.12.0 #1089

mr47 opened this issue Nov 3, 2022 · 7 comments · Fixed by #1091 or #1092

Comments

@mr47
Copy link

mr47 commented Nov 3, 2022

Bug Report

Current Behavior
On the latest version cronjobs appear to not work.

Input Code

  • REPL or Repo link if applicable:
export default CronJob(
    "api/test",
    "*/1 * * * *",
    async () => {
       console.log("Test");
    }
);

Expected behavior/code
In UI and in the logs cron jobs are visible.

Environment

  • Quirrel version: v1.12.0
  • Node/npm version: node 18
  • Next 13

Possible Solution

@mr47 mr47 changed the title Next 13 CronJobs detection fail silently in 1.12.0 Nov 3, 2022
@Skn0tt
Copy link
Member

Skn0tt commented Nov 4, 2022

hmm, I wonder if this is related to #1058 🤔

@Skn0tt
Copy link
Member

Skn0tt commented Nov 4, 2022

I'm having trouble reproducing this locally. @mr47 could you give step-by-step directions on how I can reproduce this - or even better, a reproduction repository? That'd make it a lot easier for me to fix this.

@mr47
Copy link
Author

mr47 commented Nov 4, 2022

@Skn0tt Hey sure, I'll share repo and all details that I have.

Some Info:

Next 13,
Quirrel 1.12.0
Screenshot 2022-11-04 at 22 13 31

Screenshot 2022-11-04 at 22 14 53

{
  "name": "quirrel-bug",
  "version": "0.1.0",
  "private": true,
  "scripts": {
    "dev": "concurrently 'next dev' 'quirrel'",
    "build": "next build",
    "start": "next start",
    "lint": "next lint"
  },
  "dependencies": {
    "@next/font": "^13.0.2",
    "concurrently": "^7.5.0",
    "next": "13.0.2",
    "quirrel": "^1.12.0",
    "react": "18.2.0",
    "react-dom": "18.2.0"
  },
  "devDependencies": {
    "eslint": "8.26.0",
    "eslint-config-next": "13.0.2"
  }
}

There is nothing in quirrel UI in all 3 tabs.

@mr47
Copy link
Author

mr47 commented Nov 4, 2022

@Skn0tt bare bone repo that shows no cronjobs https://github.com/mr47/quirrel-bug

Screenshot 2022-11-04 at 22 20 58

@Skn0tt
Copy link
Member

Skn0tt commented Nov 7, 2022

that's super helpful, thanks. looks like that's a regression that was introduced by a breaking change in commander.js (see #999). Working on a fix.

Skn0tt added a commit that referenced this issue Nov 7, 2022
closes #1089

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Skn0tt added a commit that referenced this issue Nov 7, 2022
🤖 I have created a release *beep* *boop*
---


##
[1.13.1](v1.13.0...v1.13.1)
(2022-11-07)


### Bug Fixes

* correctly default --no-cron
([#1091](#1091))
([1cbe816](1cbe816)),
closes [#1089](#1089)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@Skn0tt
Copy link
Member

Skn0tt commented Nov 7, 2022

@all-contributors please add @mr47 for bug

@allcontributors
Copy link
Contributor

@Skn0tt

I've put up a pull request to add @mr47! 🎉

Skn0tt pushed a commit that referenced this issue Nov 7, 2022
Adds @mr47 as a contributor for bug.

This was requested by Skn0tt [in this
comment](#1089 (comment))

[skip ci]

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants