Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add underdamped bosonic spectral density #124

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Conversation

cerisola
Copy link
Contributor

@cerisola cerisola commented Nov 27, 2024

This pr adds a convenience constructor for underdamped spectral densities frequently used in the literature.

The pr adds the new bath constructors, documentation, and tests, so I think should have all necessary features to be merged.

The implementation follows exactly the same convention as in QuTiP. I have further tested the results with those of QuTiP and they agree.

Fixes #123

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (7e6a013) to head (f416315).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   91.60%   89.85%   -1.76%     
==========================================
  Files          23       24       +1     
  Lines        1465     1478      +13     
==========================================
- Hits         1342     1328      -14     
- Misses        123      150      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytdHuang
Copy link
Member

ytdHuang commented Nov 28, 2024

Thank you for the contribution !

The content looks good to me.

Just a small problem is that the code is not Julia formatted yet, this can be done by simply running the command make format in your local PC. If you need more information, please refer to Contributing to QuantumToolbox.jl - Julia Code Format

@cerisola
Copy link
Contributor Author

Code formatting should be good now.

@ytdHuang ytdHuang merged commit 56d28c4 into qutip:main Nov 28, 2024
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for underdamped bosonic spectral densities
2 participants