Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should assignments be excluded from undesirable_function_linter? #2815

Open
MichaelChirico opened this issue Mar 5, 2025 · 0 comments
Open
Labels
false-positive code that shouldn't lint, but does

Comments

@MichaelChirico
Copy link
Collaborator

lint(text="foo <- 2", linters=undesirable_function_linter(c(foo=NA)))
# <text>:1:1: style: [undesirable_function_linter] Avoid undesirable function "foo".
# foo <- 2
# ^~~

That looks like a false positive to me. If anything, that should be covered by object_overwrite_linter() if the user wants to avoid masking foo.

@MichaelChirico MichaelChirico added the false-positive code that shouldn't lint, but does label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
false-positive code that shouldn't lint, but does
Projects
None yet
Development

No branches or pull requests

1 participant