Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Add link to dev docs in homepage for development: mode: auto #2628

Closed
olivroy opened this issue Jun 4, 2024 · 3 comments
Closed

FR: Add link to dev docs in homepage for development: mode: auto #2628

olivroy opened this issue Jun 4, 2024 · 3 comments

Comments

@olivroy
Copy link
Collaborator

olivroy commented Jun 4, 2024

Alternative to #1373 or easier solutionÉ

If development mode = "auto",

In the homepage, it would be great to have a link to dev docs?

image

It would be much simpler than #2072, while still giving a link to development documentation.

Also, for pkgdown, it is not clear to me why the View on CRAN button is only available in the dev version of the website, not released.

image

@olivroy olivroy changed the title FR: Add link to dev FR: Add link to dev docs in homepage for development: mode: auto Jun 4, 2024
@hadley
Copy link
Member

hadley commented Jun 4, 2024

Do you want to have a go at fixing this? I think you can just conditionally add the link if pkg$development$destination and pkg$development$mode == "release".

I don't know why the CRAN link didn't appear but I don't think it's related to development mode; I'd guess that cran_link("pkgdown") just randomly failed due to an internet issue.

@olivroy
Copy link
Collaborator Author

olivroy commented Jun 4, 2024

Will take a look! thanks for the tip

@olivroy
Copy link
Collaborator Author

olivroy commented Jun 4, 2024

I gotta say it feels awkward / out of place after all. So let's not go with this..

image

But it made me learn about pkgdown a little bit more.

Maybe would be better to put under Dev status, but that field is hidden on the released version. So that would require more fiddling.

@olivroy olivroy closed this as not planned Won't fix, can't repro, duplicate, stale Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants