address #2442

Author: goergen95

NEWS.md

@@ -2,6 +2,8 @@
 
 * fix build failure with GDAL < 3.4.0 #2436
 
+* `st_simplify()` now accepts feature-wise tolerance values when `s2` is switched on #2442
+
 # version 1.0-17
 
 * add `st_transform()` method for `bbox` objects; this uses OGRCoordinateTransformation::TransformBounds(), densifying first and antemeridian proof; #2415

R/geom-transformers.R

@@ -286,7 +286,12 @@ st_simplify.sfc = function(x, preserveTopology, dTolerance = 0.0) {
 	if (ll && sf_use_s2()) {
 		if (!missing(preserveTopology) && isFALSE(preserveTopology))
 			warning("argument preserveTopology cannot be set to FALSE when working with ellipsoidal coordinates since the algorithm behind st_simplify always preserves topological relationships")
-		st_as_sfc(s2::s2_simplify(x, dTolerance), crs = st_crs(x))
+	    if (length(dTolerance) == 1) {
+			st_as_sfc(s2::s2_simplify(x, dTolerance), crs = st_crs(x))
+		} else {
+			simplify <- function(x, dTolerance) st_as_sfc(s2::s2_simplify(x, dTolerance))
+			st_as_sfc(mapply(simplify, x, dTolerance), crs = st_crs(x))
+		}
 	} else {
 		if (missing(preserveTopology)) {
 			preserveTopology = FALSE

tests/gdal_geom.R

@@ -20,6 +20,8 @@ x = st_convex_hull(nc)
 
 x = st_simplify(nc_tr, dTolerance = 1e4)
 
+x = st_simplify(nc_tr, dTolerance = rep(1e4, nrow(nc_tr)))
+
 x = st_simplify(nc_tr, preserveTopology = TRUE)
 
 if (sf:::CPL_geos_version() >= "3.4.0")