Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect packet types #92

Closed
alanqthomas opened this issue Sep 17, 2022 · 1 comment
Closed

Incorrect packet types #92

alanqthomas opened this issue Sep 17, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@alanqthomas
Copy link

Describe the bug
The packet type definitions are incorrect.

For example, in game version 2022, the fields for sector 1 and 2 times are m_sector1TimeInMS and m_sector2TimeInMS, but the type definitions have them as m_sector1Time: m_sector2Time.

I've been getting around this by using @ts-expect-error annotations for the time being and just using the correct field names as defined in the actual parser.

Expected behavior
Packet type definitions should reflect the data being received, which can be different based on the game version.

@alanqthomas alanqthomas added the bug Something isn't working label Sep 17, 2022
@msansoni
Copy link
Contributor

Same as #72 - type definitions need switching based on game version (year)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants