Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependencies (index <--> theme-panel) #671

Open
Charlie-XIAO opened this issue Jan 11, 2025 · 0 comments
Open

Circular dependencies (index <--> theme-panel) #671

Charlie-XIAO opened this issue Jan 11, 2025 · 0 comments

Comments

@Charlie-XIAO
Copy link

Charlie-XIAO commented Jan 11, 2025

There seems to be circular dependencies?

   @radix-ui/themes/dist/esm/index.js
-> @radix-ui/themes/dist/esm/components/index.js
-> @radix-ui/themes/dist/esm/components/theme-panel.js
-> @radix-ui/themes/dist/esm/index.js

In particular it seems to happen here:

import {
AccessibleIcon,
Box,
Button,
Flex,
Grid,
Heading,
IconButton,
Kbd,
Popover,
ScrollArea,
Text,
Tooltip,
} from '../index.js';

I think the import above can be replaced by importing from each component instead of importing from index?

@Charlie-XIAO Charlie-XIAO changed the title Circular dependencies Circular dependencies (components/index <--> components/theme-panel) Jan 11, 2025
@Charlie-XIAO Charlie-XIAO changed the title Circular dependencies (components/index <--> components/theme-panel) Circular dependencies (index <--> theme-panel) Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant