Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in disabled InjectAsComment #27

Open
bespoyasov opened this issue Mar 9, 2018 · 1 comment
Open

Bug in disabled InjectAsComment #27

bespoyasov opened this issue Mar 9, 2018 · 1 comment

Comments

@bespoyasov
Copy link

Hi!
I think I found a bug in InjectAsComment.

With this config:

// ...
new WebpackAutoInject({
  componentsOptions: {
    InjectByTag: { 
      dateFormat: 'h:MM:ss' 
    }
  }
})

plugin works correctly and replaces [AIV]{date}[/AIV] in html-file with date string.

But when I try to disable comment injecting:

// ...
new WebpackAutoInject({
  components: {
    InjectAsComment: false,
  },
  componentsOptions: {
    InjectByTag: { 
      dateFormat: 'h:MM:ss' 
    }
  }
})

plugin won't replace [AIV]{date}[/AIV] width date anymore.

I'm not sure if this is a bug, but I supposed those features worked independently.

P.S. Thanks for the plugin! :–)

@VividWombat
Copy link

I have this problem too. issue is 2 years old, so I guess the project is abandoned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants