You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm having an issue where this plugin kept modifying indentation in my package.json even after adding PACKAGE_JSON_INDENT: 2 to the configuration. After an inspection of the dist files I noticed that PACKAGE_JSON_INDENT was nowhere to be found.
Turns out that PACKAGE_JSON_INDENT was added in a very recent pr (#39) but the source files were not recompiled.
Note: I didn't recompile dist in this PR, since my build made a lot of other unrelated changes.
So, the new config option was never really released.
My suggestion is to add a "prepublishOnly" script that compiles the files before publishing to npm. This would also mean making git ignore dist/ to avoid confusion like what happened in #39.
My other suggestion is to also, remove PACKAGE_JSON_INDENT. PACKAGE_JSON_INDENT is not necessary since the plugin could just use whatever indentation was already in use.
What do you think? I could submit pr's and address both issues.
The text was updated successfully, but these errors were encountered:
Hi @obedm503,
I've got the same issue you're writing about: the option PACKAGE_JSON_INDENT isn't considered by the latest release (1.2.2).
Everytime I build my solution, I need to format package.json file.
I'm having an issue where this plugin kept modifying indentation in my
package.json
even after addingPACKAGE_JSON_INDENT: 2
to the configuration. After an inspection of the dist files I noticed thatPACKAGE_JSON_INDENT
was nowhere to be found.Turns out that
PACKAGE_JSON_INDENT
was added in a very recent pr (#39) but the source files were not recompiled.comment
So, the new config option was never really released.
My suggestion is to add a
"prepublishOnly"
script that compiles the files before publishing to npm. This would also mean making git ignoredist/
to avoid confusion like what happened in #39.My other suggestion is to also, remove
PACKAGE_JSON_INDENT
.PACKAGE_JSON_INDENT
is not necessary since the plugin could just use whatever indentation was already in use.What do you think? I could submit pr's and address both issues.
The text was updated successfully, but these errors were encountered: