Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpris implementation issues #367

Open
kotontrion opened this issue Nov 20, 2024 · 0 comments
Open

mpris implementation issues #367

kotontrion opened this issue Nov 20, 2024 · 0 comments

Comments

@kotontrion
Copy link

From the dbus specification:

If org.freedesktop.DBus.Properties.GetAll is called with a valid interface name which contains no properties, an empty array should be returned. If it is called with a valid interface name for which some properties are not accessible to the caller, those properties should be silently omitted from the result array. If org.freedesktop.DBus.Properties.Get is called for any such properties, an appropriate access control error should be returned.

So in this project here, some properties of the mpris interface are not implemented, like eg, Position, SupportedUriSchemes and SupportedMimeTypes. Yet when calling org.freedesktop.DBus.Properties.Get for those properties, blanket will return false, but according to the dbus specification it should return an error.

We came across this issue with the mpris library from this project. Valas dbus proxy will try to get those properties and will crash when trying to unpack the variant, as the types do not match. When an error is returned instead of falseeverything works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant