-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What was the resolution of #49 regarding non-digest assets? #343
Comments
There is no update. It is something in our radar but not a priority. |
That isn't consistent with your previous post:
What are those improvements? How do we take advantage of them? |
The improvements were raising an exception when a non-digest asset is referenced. You don't need to do anything to take advantage of it, it is enabled by default. |
I see. That is not the behavior we experience on 2.3.3. Even if it were, I do not see how that addresses the problem. What can a contributor do to make progress on this? You mentioned that it is on the radar but not a priority, which is a good case for a contributor to take on. |
That is an open pull request. What can a contributor do to make progress on this? |
@celsodantas do you understand what the next steps are here? |
It depends which problem are we trying to solve. The problem we are trying to solve is: there is some assets that we don't want to generate digest. But there are people that want: we want to generate a version of each asset in our application that don't have a digest. We want to solve the first problem, but we don't want to solve the second problem. #49 talks about both. Which problem are you expecting to be solved? |
I'm really asking what you were talking about when you said:
cc @alexspeller |
The way is #239. But it can be other ways that we still didn't thought about. |
Then I guess I'll just ask the same question I asked yesterday: That is an open pull request. What can a contributor do to make progress on this? Why isn't it merged? |
In reality nothing. The value of the feature proposed there and discussed in #49 is still unsure. I'm still evaluating if it is worth the complexity in the library due the fact of removing caching digest will invalidate a core principle of sprockets that is generating assets with digest so they can be cached forever in the CDN. The use cases still don't justify having support for this built-in in the library. There are alternatives and I believe the rake task presented in #49 (comment) is sufficient for most of the cases. This is why I asked: which problems do you think removing the digest from the assets will solve? |
I think there are lots of issues caused here, such as the inability to However, for me, the largest motivator is for email. Right now, we refer to I am not even touching the plethora of people who are simply frustrated by Data indicates that hundreds of developers over tens of thousands of On Wed, Apr 27, 2016 at 5:27 PM Rafael França [email protected]
|
If the non-stupid-digest-assets gem works why not keeping using it? Including it in sprockets-rails disabled by default will still require users to understand their problems, so including it in sprockets-rails doesn't solve the knowledge problem. Including it in sprockets-rails enabled by default will require users that don't need this feature to pay the price. I really don't want to do it. That said, I personally don't want to do anything about this issue. In my opinion it is already solved by non-stupid-digest-assets and I don't want to maintain a code which I don't use or even agree. Others may disagree with me and want to implement this feature, it us up to them. |
The problem is the amount of time it takes for someone to realize that they I don't want to change the default behavior. I just want to give people the On Wed, Apr 27, 2016 at 5:52 PM Rafael França [email protected]
|
Should we then update the README for the use case? Maybe pointing to the |
Let's stick to the pull request and concrete work. We have a surplus of fully-hashed-out debate on this topic. |
@rafaelfranca you made a comment here: #49
...but that thread still has a lot of people flowing to it, and they don't know where to go. Your comment doesn't explain what the resolution or plan is, so over two years later, we are still working around this gems like https://github.com/alexspeller/non-stupid-digest-assets
Can you please give us an update, and make sure that thread sees it? Many places on the web about the issue link to that thread.
The text was updated successfully, but these errors were encountered: