Exit with status 1 on tests failure

Author: alchaplinsky

__mocks__/child_process.js

@@ -1,4 +1,4 @@
 export const spawn = jest.fn()
-export const spawnSync = jest.fn()
+export const spawnSync = jest.fn().mockReturnValue({ status: 0 })
 
 export default { spawn, spawnSync }

__test__/runner/index.test.js

@@ -46,20 +46,36 @@ describe('start', () => {
 })
 
 describe('test', () => {
-  it('calls test runner without options', () => {
-    test()
+  it('calls test runner without options', async () => {
+    await test()
     expect(TestRunner.run).toHaveBeenCalled()
   })
 
-  it('calls test runner with path', () => {
-    test('test/index.test.js')
+  it('calls test runner with path', async () => {
+    await test('test/index.test.js')
     expect(TestRunner.run).toHaveBeenCalledWith('test/index.test.js')
   })
 
-  it('restores cursor', () => {
-    test()
+  it('restores cursor', async () => {
+    await test()
     expect(restoreCursorOnExit).toHaveBeenCalled()
   })
+
+  it('exits with success status', async () => {
+    await test()
+    expect(process.exit).toHaveBeenCalledWith(0)
+  })
+
+  describe('running test fails', () => {
+    beforeEach(() => {
+      TestRunner.__setError(Error)
+    })
+
+    it('exits with error status', async () => {
+      await test()
+      expect(process.exit).toHaveBeenCalledWith(1)
+    })
+  })
 })
 
 describe('package', () => {

src/__mocks__/test_runner.js

@@ -1 +1,14 @@
-export const TestRunner = { run: jest.fn().mockResolvedValue(true) }
+let testError = null
+
+export const TestRunner = {
+  __setError: error => {
+    testError = error
+  },
+  run: jest.fn(() => {
+    if (testError) {
+      return Promise.reject(testError)
+    } else {
+      return Promise.resolve()
+    }
+  })
+}

src/runner/index.js

@@ -23,20 +23,22 @@ export const start = command => {
   } else if (command.inspectBrk) {
     params.options = ['--inspect-brk=' + command.inspectBrk]
   }
-  Starter.run(params)
+  return Starter.run(params)
 }
 
 export const pack = (platform, command) => {
   restoreCursorOnExit()
-  new Packager(platform, 'production', !!command.publish).build()
+  return new Packager(platform, 'production', !!command.publish).build()
 }
 
 export const test = (path) => {
   restoreCursorOnExit()
-  TestRunner.run(path)
+  return TestRunner.run(path)
+    .then(() => process.exit(0))
+    .catch(() => process.exit(1))
 }
 
 export const clear = () => {
   restoreCursorOnExit()
-  Cleaner.run()
+  return Cleaner.run()
 }

src/test_runner/index.js

@@ -8,10 +8,10 @@ import { log } from 'utils/logger'
 const run = path => {
   Checker.ensure()
   if (!path || path.match(/features/)) {
-    buildAndRun(path)
+    return buildAndRun(path)
   } else {
     log(chalk.bold('Running test suite...'))
-    runUnitTests(path)
+    return runUnitTests(path)
   }
 }
 
@@ -26,25 +26,34 @@ const buildAndRun = path => {
 }
 
 const runFeatureTests = path => {
-  spawnSync('npx', ['jest', '-i', path], {
+  const result = spawnSync('npx', ['jest', '-i', path], {
     env: nodeEnv('test'),
     shell: true,
     stdio: 'inherit'
   })
+  return buildPromise(result.status)
 }
 
 const runUnitTests = path => {
-  spawnSync('npx', ['jest', path], {
+  const result = spawnSync('npx', ['jest', path], {
     env: nodeEnv('test'),
     shell: true,
     stdio: 'inherit'
   })
+  return buildPromise(result.status)
 }
 
 const runAllTests = () => {
-  runUnitTests('./test/units')
-  runFeatureTests('./test/features')
-  return Promise.resolve()
+  return Promise.all([
+    runUnitTests('./test/units'),
+    runFeatureTests('./test/features')
+  ])
+}
+
+const buildPromise = status => {
+  return (status === 0)
+    ? Promise.resolve()
+    : Promise.reject(Error('Some tests failed'))
 }
 
 export const TestRunner = { run }