Help converting 3rd person Camera script to use via PhantomCamera

[KatieMew]

I am trying to convert this camera movement script I have to be usable with PhantomCameras. Below is the current script I have

func camera_shake():
	var initial_transform = self.transform 
	var elapsed_time = 0.0
	
	while elapsed_time < period:
		var offset = Vector3(
			randf_range(-magnitude, magnitude),
			randf_range(-magnitude, magnitude),
			0.0
		)
	
		self.transform.origin = initial_transform.origin + offset
		elapsed_time += get_process_delta_time()
		await get_tree().process_frame
	self.transform = initial_transform

func _input(event):
	if player_node.canMove:
		# Handle mouse movements for camera
		if event is InputEventMouseMotion:
			var horizontal_rotation = event.relative.x * sens_horizontal
			rotate_y(deg_to_rad(-horizontal_rotation))
	
			var vertical_rotation = -event.relative.y * sens_vertical
			var current_rotation = rotation_degrees.x
			var clamped_rotation = clamp(current_rotation + vertical_rotation, -60, 40)
			rotation_degrees.x = clamped_rotation

func _process(delta):
	if player_node.canMove:
		# Handle joystick movements for camera
		var joystick_horizontal = Input.get_action_strength("cameraRight_controller") - Input.get_action_strength("cameraLeft_controller")
		var joystick_vertical = Input.get_action_strength("cameraDown_controller") - Input.get_action_strength("cameraUp_controller")
	
		if abs(joystick_horizontal) > DEADZONE:  # Deadzone threshold
			var horizontal_rotation = joystick_horizontal * joy_sens_horizontal * delta
			rotate_y(deg_to_rad(-horizontal_rotation))
	
		if abs(joystick_vertical) > DEADZONE:  # Deadzone threshold
			var vertical_rotation = -joystick_vertical * joy_sens_vertical * delta
			var current_rotation = rotation_degrees.x
			var clamped_rotation = clamp(current_rotation + vertical_rotation, -60, 20)
			rotation_degrees.x = clamped_rotation
	
		if Input.is_action_just_pressed("alignCamera"):
			align_in_progress = true
			calculate_target_yaw()
	
		if align_in_progress:
			alignCameraToPlayerDirection(delta)

func _physics_process(delta):
	if not player_node.stopCamera:
		follow_player(delta)

func calculate_target_yaw():
	var forward_direction = -player_node.player.last_saved_direction.normalized()
	
	if forward_direction == Vector3.ZERO:
		forward_direction = -global_transform.basis.z

	if forward_direction != Vector3.ZERO:
		target_yaw = atan2(forward_direction.x, forward_direction.z)

func alignCameraToPlayerDirection(delta):
	var current_yaw = rotation.y
	var interpolation_speed = 15.0
	var new_yaw = lerp_angle(current_yaw, target_yaw, interpolation_speed * delta)

	rotation.y = new_yaw

	if abs(new_yaw - target_yaw) < 0.01:
		align_in_progress = false

func follow_player(delta):        
	global_transform.origin = global_transform.origin.lerp(player_node.player.global_transform.origin, 15.0 * delta)

specifically, im not necessarily sure what to change some of the syntax to. as far as the vertical rotation of the camera, im assuming it's using: PlayerCam.set_third_person_rotation(), but i have no clue on what exactly to change regarding what i currently have. The script is applied to a camera_mount Node3D. any help on this would be appreciated!

[ramokz]

Based on your code sample, there are a few places where the rotation seems to be set, so my guess would be that the change would need to occur where you've currently written:

# Note: In all instances
# rotation_degrees.x = clamped_rotation
pcam.set_third_person_rotation_degrees(Vector3(clamped_rotation, rotation_degrees.y, rotation_degrees.z))

# rotation.y = new_yew
pcam.set_third_person_rotation(Vector3(rotation.x, new_yew, rotation.z))

Though, it's difficult to say whether if the above works without the wider context of the scene setup.

[KatieMew]

This was it, I did end up finding it out after a while, but thank you for the response!