Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RKE2 does not bundle RuntimeClass definitions #7242

Open
brandond opened this issue Nov 7, 2024 · 0 comments
Open

RKE2 does not bundle RuntimeClass definitions #7242

brandond opened this issue Nov 7, 2024 · 0 comments
Assignees
Labels
kind/bug Something isn't working

Comments

@brandond
Copy link
Member

brandond commented Nov 7, 2024

Follow up to:

We created a chart with RuntimeClass definitions, but never actually added it to RKE2:

We need to:

  1. Ensure that the rke2-runtimeclasses chart is still in sync with all the supported runtime classes that are detected by k3s/rke2. In particular, I suspect that nvidia-smi may be missing.
  2. Add that chart to RKE2.
  3. Ensure that RKE2 assigns ownership of any supported RuntimeClass definitions to the rke2-runtimeclasses chart so that the helm install does not fail to install and go into crashloop backoff due to conflicting unmanaged resources. We should NOT take ownership of any runtimeclass definitions not managed by the chart, so that users can add their own.

For the final goal, this would probably look like a startup hook similar to https://github.com/rancher/rke2/blob/master/pkg/rke2/kp.go that iterates over the supported runtimeclass definitions and adds the correct helm labels/annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants