Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systematically time all test suites #4417

Open
randombit opened this issue Oct 28, 2024 · 1 comment
Open

Systematically time all test suites #4417

randombit opened this issue Oct 28, 2024 · 1 comment
Assignees

Comments

@randombit
Copy link
Owner

Some but not all of the tests report how long they took. Fix this.

Also the time reported should be normalized to always print seconds, instead of in ms if fast but in seconds if > 1 s.

@randombit randombit self-assigned this Oct 28, 2024
@KaganCanSit
Copy link
Contributor

KaganCanSit commented Nov 10, 2024

Hello, @randombit @reneme

I have made the necessary changes for this bug report, but I think it would be useful to evaluate the situation I encountered and get more information in general.

First, I made adjustments to print duration values in seconds with a precision of 6 digits.

Next, I went through the test output and added calls to tests that did not have time measurement calls. This change required me to update quite a lot of files. Here, I thought about adjusting the time in the constructor and destructor of the result object, or evaluating different ideas, but I didn't want to break the existing code structure, considering the situation with the fields where the object is held in the vector.

After these changes, I noticed that when I ran the tests, the duration values ​​were not always printed due to the "if (m_ns_taken) > 0" condition of the "std::string Test::Result::result_string()" function in "test.cpp".

I tried to make these changes quickly (over the weekend), but I will review them again. At this point, I would like your guidance on the time measurement and the if condition I mentioned above.

I would love to work on this bug report if you can. (I didn't want to create a merge request for now.)

Commits:
KaganCanSit@0182be7
KaganCanSit@8bc8988

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants