Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide cleaner API for anchor prop of Menu #6

Open
ranile opened this issue May 19, 2021 · 0 comments
Open

Provide cleaner API for anchor prop of Menu #6

ranile opened this issue May 19, 2021 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ranile
Copy link
Owner

ranile commented May 19, 2021

Menu's anchor prop take has signature of anchor: Option<web_sys::HtmlElement>. It's clunky and difficult to use. For example, need to have HtmlElement of the element which isn't possible to obtain in view before returning. The only method of setting it right now that I know of is by using WeakComponentLink::<MatMenu>::set_anchor in after the component is rendered. We need to provide a more elegant API for this.
@ranile ranile added enhancement New feature or request help wanted Extra attention is needed labels May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ranile