Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Enable per thread default streams in pylibcudf #17919

Open
Matt711 opened this issue Feb 5, 2025 · 2 comments
Open

[FEA] Enable per thread default streams in pylibcudf #17919

Matt711 opened this issue Feb 5, 2025 · 2 comments
Assignees
Labels
feature request New feature or request

Comments

@Matt711
Copy link
Contributor

Matt711 commented Feb 5, 2025

Is your feature request related to a problem? Please describe.
We should enable per thread default streams in pylibcudf.

Describe the solution you'd like
I think we can do this by exposing cudf::is_ptds_enabled in pylibcudf and using it to set the default stream to PER_THREAD_DEFAULT_STREAM from pylibrmm.

Describe alternatives you've considered
None

Additional context
#17620

@Matt711 Matt711 added the feature request New feature or request label Feb 5, 2025
@Matt711 Matt711 self-assigned this Feb 5, 2025
@vyasr
Copy link
Contributor

vyasr commented Feb 5, 2025

Did you see #17626? I don't know if we will ever ship builds for Python usage that have PTDS enabled at compile-time by default. If we did, though, rather than using is_ptds_enabled couldn't we just wrap get_default_stream in Python directly?

@Matt711
Copy link
Contributor Author

Matt711 commented Feb 5, 2025

Did you see #17626? I don't know if we will ever ship builds for Python usage that have PTDS enabled at compile-time by default. If we did, though, rather than using is_ptds_enabled couldn't we just wrap get_default_stream in Python directly?

No I didn't, thanks for the link. Yes I think we could just expose get_default_stream. It would look something likecpdef Stream get_default_stream().

I assigned #17626 to me, but we can probably discuss this more offline before I start actively working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants