Skip to content

Commit 0fb0b15

Browse files
authored
Disable custom truncate behavior (#105)
See #104 for details. Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Lawrence Mitchell (https://github.com/wence-) URL: #105
1 parent aab814d commit 0fb0b15

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

cpp/src/request_tag.cpp

+8-7
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,14 @@ RequestTag::RequestTag(std::shared_ptr<Component> endpointOrWorker,
6262

6363
void RequestTag::callback(void* request, ucs_status_t status, const ucp_tag_recv_info_t* info)
6464
{
65-
if (status != UCS_ERR_CANCELED && info->length != _length) {
66-
status = UCS_ERR_MESSAGE_TRUNCATED;
67-
const char* fmt = "length mismatch: %llu (got) != %llu (expected)";
68-
size_t len = std::snprintf(nullptr, 0, fmt, info->length, _length);
69-
_status_msg = std::string(len + 1, '\0'); // +1 for null terminator
70-
std::snprintf(_status_msg.data(), _status_msg.size(), fmt, info->length, _length);
71-
}
65+
// TODO: Decide on behavior. See https://github.com/rapidsai/ucxx/issues/104 .
66+
// if (status != UCS_ERR_CANCELED && info->length != _length) {
67+
// status = UCS_ERR_MESSAGE_TRUNCATED;
68+
// const char* fmt = "length mismatch: %llu (got) != %llu (expected)";
69+
// size_t len = std::snprintf(nullptr, 0, fmt, info->length, _length);
70+
// _status_msg = std::string(len + 1, '\0'); // +1 for null terminator
71+
// std::snprintf(_status_msg.data(), _status_msg.size(), fmt, info->length, _length);
72+
// }
7273

7374
Request::callback(request, status);
7475
}

python/ucxx/_lib_async/tests/test_send_recv.py

+1
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ async def test_send_recv_numba(size, dtype):
120120

121121

122122
@pytest.mark.asyncio
123+
@pytest.mark.skip(reason="See https://github.com/rapidsai/ucxx/issues/104")
123124
async def test_send_recv_error():
124125
async def say_hey_server(ep):
125126
await ep.send(bytearray(b"Hey"))

0 commit comments

Comments
 (0)