Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 files missing license header #145

Open
recursivenomad opened this issue Jun 17, 2024 · 9 comments
Open

5 files missing license header #145

recursivenomad opened this issue Jun 17, 2024 · 9 comments

Comments

@recursivenomad
Copy link

recursivenomad commented Jun 17, 2024

The following files do not contain license information, and therefore cannot be forked/included in other projects:

As this has happened before (#5), it may be worth considering a license file in the root of the repository to serve as a fallback license for future files which lack license headers.

Edit

Build files are also missing license information:

@recursivenomad recursivenomad changed the title 2 files missing license header 5 files missing license header Jun 19, 2024
@recursivenomad
Copy link
Author

I have begun working on a derivative work and would like to use probe_oen.pio in it, however its lack of license header (and the project's lack of a root license file) means the code is "all rights reserved" and unable to legally be reused.

Although the file would be straightforward to recreate with clean-room design, I would prefer to be able to use and contribute back to the original file if possible.

@P33M
Copy link
Contributor

P33M commented Nov 13, 2024

FreeRTOS_Kernel_import.cmake and pico_sdk_import.cmake are direct copies from the pico-sdk, which is BSD 3-clause, so I will add a header to those.
probe_config.c and probe_oen.pio are third-party contributions, and attribution/licence has been requested.
There are other contributors to cmakelists.txt and I willl CC them in the next comment.

All other files have a licence header - originally the project was designated MIT licenced, and going forward we'll specify that.

Edit: the FreeRTOS_Kernel_import.cmake file is redundant and removed as it is now pulled in directly from the submodule.

@P33M
Copy link
Contributor

P33M commented Nov 13, 2024

@a-pushkin @newbrain @rewolff @fduxiao thank you for your contributions to this project, however we have a request.

Some of your edits were to the file CMakeLists.txt and this file was not tagged with an OSS licence (and neither was the overall project). Please confirm that you are the original authors of your work and that you are happy to contribute on the basis that this file is MIT licenced.

https://opensource.org/license/mit

@rewolff
Copy link
Contributor

rewolff commented Nov 13, 2024

I hereby declare that my contributions to this project can be included in this project and distributed and used under the licence that this project is licenced under, in this case the so-called MIT licence.

@P33M
Copy link
Contributor

P33M commented Nov 20, 2024

@rewolff Thanks for confirming.

probe_oen.pio attribution has been resolved in 9aed4ca
pico_sdk_import.cmake has been clarified as to the original file's license in 8f5d6fc

I will ping the other authors again...

@newbrain
Copy link
Contributor

My contributions can be used and distributed according to the MIT license or any OSI registered form of the BSD license.
Please let me know if further action is needed on my part.

@fduxiao
Copy link

fduxiao commented Nov 21, 2024

My work is on my own and can be used or distributed under those licenses.

@chrisboross
Copy link

@a-pushkin Sorry to nag! We'd really like to hear back from you?

@P33M
Copy link
Contributor

P33M commented Nov 27, 2024

I have removed the remaining unattributed lines surviving in the project, asked @andygpz11 to do a cleanroom reimplementation of the missing functionality, and have tagged it as MIT licensed.
65b1e73

Thanks to those for confirming that their work is OSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants