Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include playground_auto_set_url #47

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Include playground_auto_set_url #47

wants to merge 5 commits into from

Conversation

jcarranz97
Copy link
Contributor

Fixes #46

Include modified version of example_auto_set_url.cmake to be able to use example_auto_set_url

@jcarranz97 jcarranz97 changed the title Include example auto set url Include example_auto_set_url Dec 4, 2023
lurch
lurch reviewed Dec 4, 2023
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
lurch
lurch reviewed Dec 4, 2023
View reviewed changes
example_auto_set_url.cmake Outdated Show resolved Hide resolved
@jcarranz97 jcarranz97 requested a review from lurch December 5, 2023 01:55
@lurch lurch changed the title Include example_auto_set_url Include playground_auto_set_url Dec 5, 2023
@jcarranz97
Copy link
Contributor Author

Thanks for the advice. I have made the change and I have also include PICO_PLAYGROUND_PATH in the CMakeLists.txt

@lurch lurch removed their request for review December 7, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lurch lurch lurch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not able to build repository - Unknown CMake command Include build folder as part of .gitignore
2 participants
@jcarranz97 @lurch