Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can has unislope? #357

Open
o-smirnov opened this issue Dec 18, 2024 · 3 comments
Open

Can has unislope? #357

o-smirnov opened this issue Dec 18, 2024 · 3 comments

Comments

@o-smirnov
Copy link
Collaborator

How difficult would it be to revive the "unislope" functionality in the delay_and_offset? Maybe a common_delay_and_offset?

@JSKenyon
Copy link
Collaborator

JSKenyon commented Dec 18, 2024

I actually wanted to add this as a scalar mode to all the appropriate solvers i.e. on all terms which aren't 2x2 by definition. Will try to come up with something - in principle it is just a tiny tweak prior to the computation of the update. That said, I will not support mixing scalar and non-scalar behaviour for a single term i.e. if one specifies a scalar delay_and_offset, you will get a single delay, and a single offset. More complex behaviour can be accomplished by mixing terms i.e. a non-scalar phase plus a scalar delay would result in a phase estimate per correlation and a delay estimate over both. Is that adequate?

@o-smirnov
Copy link
Collaborator Author

More complex behaviour can be accomplished by mixing terms i.e. a non-scalar phase plus a scalar delay

Yep, nice and clean and easy to express.

@JSKenyon
Copy link
Collaborator

An experimental version of this functionality has been added in #358. It could use some testing in the wild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants