Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "std" feature instead of / in addition to "use_std"? #26

Open
oconnor663 opened this issue Aug 5, 2018 · 3 comments
Open

Add a "std" feature instead of / in addition to "use_std"? #26

oconnor663 opened this issue Aug 5, 2018 · 3 comments

Comments

@oconnor663
Copy link

There's some guidance that suggests std is a more idiomatic feature name than use_std: https://rust-lang-nursery.github.io/api-guidelines/naming.html#feature-names-are-free-of-placeholder-words-c-feature

@cuviper
Copy link
Member

cuviper commented Aug 6, 2018

Renaming it would be a breaking change, but we could add "std" as an alternate.

I think the only time "use_std" would even be mentioned normally is for another crate that is also conditionally using std. Otherwise you just choose either with default features or not.

@oconnor663
Copy link
Author

Good point.

@Stargateur
Copy link

Stargateur commented Jul 20, 2022

must say I would also push to have a feature std and depreciate use_std. Also, serde should probably be imported using default-feature = false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants