Impl fmt::Write for Either

[yotamofek]

Found myself needing this (while working on rustdoc).

[jswrenn]

Thanks for the PR! Just one small nit/question.

Happy to hear we can do something to make rustdoc a little better. :)

[jswrenn]

If you write this instead, can you do this without the ref mut?

Suggested change

	for_both!(*self, ref mut inner => inner.write_str(s))
	for_both!(self, inner => inner.write_str(s))

[yotamofek]

Fixed and rebased.
BTW, I was doing this just to be consistent with the rest of the code, e.g.:

either/src/lib.rs

Line 1410 in bd0fe70

for_both!(*self, ref inner => inner.fmt(f))

[jswrenn]

Looks like that was pushed 10 years ago, so it's either a historical accident, or.a quirk of pattern ergonomics.

We'll see if the change passes CI...

[yotamofek]

Probably happened before match ergonomics were improved. I was gonna open a PR to simplify all those patterns, but have already opened 3 just today, so I'll wait with that. 😅

[jswrenn]

LGTM!

[yotamofek]

BTW, I was surprised CI is green without #112 , but I think it's just because the registry is cached!

[jswrenn]

In my experience with maintaining zerocopy (msrv of 1.55), if you blow away the Cargo.lock then build on an old toolchain, the toolchain selects compatible crate versions.

[yotamofek]

Except 1.37 is so old it doesn't respect the rust-version field. Or maybe that's a pretty new functionality, I'm not sure.
I'll make sure later I was building without a Cargo.lock

[cuviper]

Ah, I could have sworn we already had this, but that was io::Write. Thanks!