A yield_now/yield_local alternative that allows the thread to go to sleep

[james7132]

We're investigating using rayon as Bevy's thread pool and scheduler, and part of that requires being able to schedule futures onto the task pool. This has been partially doable with the suggested implementations in the discussion in #679, but we're running into issues where futures::block_on equivalents cannot yield to the thread pool in a way that will put the thread to sleep if there is no available work, nor a way to, on-demand, wake that specificthread back up. futures_lite::block_on and it's variants park the thread using parking or the std equivalent in std::thread::park, but rayon does not expose any option for this level of control. Using the aforementioned options for parking the thread leads to excessive CPU usage and contention, likely due to conflicting with rayon's internal state of how threads should be managed.

A yield_sleep or yield_park equivalent that hooks into the internal thread sleeping state when called, and a corresponding data type that we can wrap as a Waker would be really useful here.

[cuviper]

Can you sketch what this might look like from the outside?

[james7132]

pub struct Parker;
pub struct Unparker;

impl Parker {
    /// Either does one job, or does an additional round of polling via Sleep, eventually putting the thread to sleep, blocking the
    /// thread until woken up by rayon or the provided Waker.
    pub fn yield_or_sleep(&self) -> Yield {}
}

// The converted Wakes up the paired thread.
impl From<Unparker> for std::task::Waker {
    ...
}

/// Linked to WorkerThread::current
pub fn pair() -> (Parker, Unparker) {}

If this is too much to expose to a public interface, it's probably fine to also just have this internally inside rayon_core to make a potential rayon_core::futures::block_on as an equivalent to futures_lite::futue::block_on.

[cuviper]

it's probably fine [...] to make a potential rayon_core::futures::block_on

Oh! I had a prototype of that -- here it is dusted off and rebased:
main...cuviper:rayon:block_on

[mtantaoui]

Hello, I would like to work on this one, do you have a piece od code that I can use to reproduce this one ?