Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added .fromQuad and .fromTerm methods #28

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Conversation

bergos
Copy link
Contributor

@bergos bergos commented Jun 30, 2021

fixes #16

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2021

Codecov Report

Merging #28 (ae637ef) into master (5e677b6) will increase coverage by 0.83%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   95.91%   96.75%   +0.83%     
==========================================
  Files           8        9       +1     
  Lines         147      185      +38     
==========================================
+ Hits          141      179      +38     
  Misses          6        6              
Impacted Files Coverage Δ
lib/data-factory.js 92.30% <100.00%> (+0.64%) ⬆️
lib/fromTerm.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e677b6...ae637ef. Read the comment docs.

@bergos bergos merged commit 079950f into master Jun 30, 2021
@bergos bergos deleted the from-term-quad branch June 30, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement fromTerm and fromQuad
2 participants