Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTCView should support null stream #16

Open
wilkinsonj opened this issue Jul 6, 2024 · 1 comment
Open

RTCView should support null stream #16

wilkinsonj opened this issue Jul 6, 2024 · 1 comment
Labels
confirmed The issue has been confirmed enhancement New feature or request

Comments

@wilkinsonj
Copy link

Describe the bug

The native RTCView can be provided a streamURL of null, for example streamUrl={localStream?.toURL()}

However, the RTCView in this library throws an error if localStream is null, for example stream={localStream}

It would be better if stream had the same logic behind the scenes

@8BallBomBom 8BallBomBom added enhancement New feature or request confirmed The issue has been confirmed labels Jul 6, 2024
@8BallBomBom
Copy link
Member

8BallBomBom commented Jul 6, 2024

Understandable, there are a few things which definitely need pulling into line.
Will put this on the list for the next major update 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed The issue has been confirmed enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants