-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature : Enable variant Serializers - Newtonsoft, System.Text.Json #882
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #882 +/- ##
==========================================
- Coverage 61.05% 60.25% -0.80%
==========================================
Files 58 60 +2
Lines 2321 2370 +49
Branches 363 380 +17
==========================================
+ Hits 1417 1428 +11
- Misses 733 755 +22
- Partials 171 187 +16 ☔ View full report in Codecov by Sentry. |
Encryption needs to be resolved or removed for
any news? |
@listepo Unfortunately the features of the original Akavache use parts of Newtonsoft.Bson which there is no equivalent for System.Text.Json. |
Due to the fact that stripping all the features out will be an exact match to Reactivemarbles.CacheDatabase I am closing this PR |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What kind of change does this PR introduce?
Feature - resolves #666
What is the current behavior?
Only allows for Newtonsoft serializer.
What is the new behavior?
Adds ability to switch Json Serializers.
What might this PR break?
Akavache will no longer have a default Json Serializer and users will need to add an additional package
Akavache.Newtonsoft OR Akavache.Json
Please check if the PR fulfills these requirements
Other information: