Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect implementation of onTransitionEnd #914

Open
X-Y opened this issue Dec 4, 2024 · 0 comments
Open

Incorrect implementation of onTransitionEnd #914

X-Y opened this issue Dec 4, 2024 · 0 comments

Comments

@X-Y
Copy link

X-Y commented Dec 4, 2024 •
edited
Loading

What is the current behavior?

addEndListener on Transition has two arguments, node and done. node is a function and done is undefined.

What is the expected behavior?

node should be the nodeRef and done should be a function

Look at this line:
https://github.com/reactjs/react-transition-group/blame/2989b5b87b4b4d1001f21c8efa503049ffb4fe8d/src/Transition.js#L350

if this.props.nodeRef exists, then maybeNode becomes this.nextCallback and maybeNextCallback becomes undefined?

Could you provide a CodeSandbox demo reproducing the bug?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@X-Y