Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add yoruba lang file #274

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ademola-raimi
Copy link

@ademola-raimi ademola-raimi commented Apr 26, 2023

I have experience in implementing translation in ReactJS. I used the react-i18next library for translation while working on the Blitz project. I have also implemented translation on other stacks that are not reactJS based.

List of maintainers

@DonAlkens
@Innykemi

Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a part of fixing the permission sync process, we've changed how we track languages — please see 63a10c4.
Could you please update this PR:

  • Rebase on top of latest main, and add the language to lang/langs.json instead
  • Include the list of maintainers into the PR comment body instead

Thank you, and sorry for the churn.

@gaearon
Copy link
Member

gaearon commented Apr 29, 2023

Ideally we'd like maintainers to have some experience of translating itself since it can be tricky and daunting for the first time. Do you have some, or know someone who can help?

@ademola-raimi
Copy link
Author

As a part of fixing the permission sync process, we've changed how we track languages — please see 63a10c4. Could you please update this PR:

  • Rebase on top of latest main, and add the language to lang/langs.json instead
  • Include the list of maintainers into the PR comment body instead

Thank you, and sorry for the churn.

Done

@ademola-raimi
Copy link
Author

Ideally we'd like maintainers to have some experience of translating itself since it can be tricky and daunting for the first time. Do you have some, or know someone who can help?

I will check around, I think @DonAlkens has some experience in translation, can you confirm? Also, I have actually worked on translating without a library in some other stack like PHP Phalcon. I don't think it would be a problem. I assume it would be the same concept. @gaearon

Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find at least one other translator committed to maintaining this translation, and ask them to comment on this PR with a confirmation. Thank you!

@gaearon gaearon added the needs more maintainers More maintainers needed label May 18, 2023
@Innykemi
Copy link

Hi @gaearon i'm committed to maintaining this translation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs more maintainers More maintainers needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants