Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

job: deleted column is not used #221

Open
mdonadoni opened this issue Jan 23, 2024 · 1 comment
Open

job: deleted column is not used #221

mdonadoni opened this issue Jan 23, 2024 · 1 comment
Labels
priority/longterm size/m type/bug Something isn't working

Comments

@mdonadoni
Copy link
Member

It seems like the deleted column in the Job table is not used.

reana-db/reana_db/models.py

Line 835 in 7c616d6

deleted = Column(Boolean)

Note that job-controller uses a deleted field in its in-memory database, but that value is not persisted to PostgreSQL, for example: https://github.com/reanahub/reana-job-controller/blob/e6742f2911df46dfbef3b7e9104330d58e2b4211/reana_job_controller/rest.py#L245
@mdonadoni mdonadoni added the type/bug Something isn't working label Jan 23, 2024
@mdonadoni mdonadoni added this to 0.95.0 Aug 8, 2024
@mdonadoni mdonadoni moved this to Backlog in 0.95.0 Aug 8, 2024
@mdonadoni
Copy link
Member Author

We can probably drop this column, so we will need an alembicmigration recipe, too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/longterm size/m type/bug Something isn't working
Projects
0.95.0
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdonadoni