Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better LLVM detection in the vprc binary #54

Open
griwes opened this issue May 21, 2019 · 0 comments
Open

Better LLVM detection in the vprc binary #54

griwes opened this issue May 21, 2019 · 0 comments

Comments

@griwes
Copy link
Member

griwes commented May 21, 2019

Currently, vprc is hardcoded to search for llvm-config. It should try to detect LLVM more widely, since sometimes llvm-config is missing; we should also look for llvm-config-[0-9]+.

Additionally, the process launch for LLVM binaries should be wrapped in try-catch - the current method of error detection from running those processes is just to check for an exit code, but it seems that Boost.Process throws an exception on launch failure. Oops.

@griwes griwes added this to the Release v0.1 milestone May 21, 2019
@griwes griwes self-assigned this May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant