-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pandaproxy/sr: protobuf rendering: refactor string rendering #24992
Merged
IoannisRP
merged 1 commit into
redpanda-data:dev
from
IoannisRP:ik-pandaproxy-sr-pb-refactor-string-rendering
Feb 1, 2025
Merged
pandaproxy/sr: protobuf rendering: refactor string rendering #24992
IoannisRP
merged 1 commit into
redpanda-data:dev
from
IoannisRP:ik-pandaproxy-sr-pb-refactor-string-rendering
Feb 1, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved away from fmt debug format for 2 reasons: 1. Debug format is not supported in earlier versions of fmt that we still use. 2. Make the intent more explicit.
BenPope
approved these changes
Jan 31, 2025
This was referenced Jan 31, 2025
CI test resultstest results on build#61451
|
/backport v24.3.x |
/backport v24.2.x |
Failed to create a backport PR to v24.3.x branch. I tried:
|
Failed to create a backport PR to v24.2.x branch. I tried:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: CORE-8906
Refactored string rendering to use
absl::CEscape
instead of fmt debug format.It is done for 2 reasons:
Backports Required
Release Notes