Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module side panel - show all module information #4301

Closed
vio opened this issue Mar 4, 2024 · 7 comments · Fixed by #4648
Closed

Module side panel - show all module information #4301

vio opened this issue Mar 4, 2024 · 7 comments · Fixed by #4648
Assignees
Labels
feature New feature or request

Comments

@vio
Copy link
Member

vio commented Mar 4, 2024

Include all module information:

  • duplicate size
  • total size
  • chunk count

rel: #3929 (comment)

@vio vio changed the title Module side panel - show all the information Module side panel - show all module information Mar 4, 2024
@vio vio added the feature New feature or request label Mar 4, 2024
@vio vio added this to the 4.14.0 - module duplicate size milestone Mar 4, 2024
Copy link
Contributor

github-actions bot commented Jun 3, 2024

This issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the stale label Jun 3, 2024
@steverep
Copy link

steverep commented Jun 3, 2024

Activity...

@github-actions github-actions bot removed the stale label Jun 4, 2024
@vio vio self-assigned this Jul 24, 2024
@vio vio closed this as completed Aug 4, 2024
@vio
Copy link
Member Author

vio commented Aug 5, 2024

image

Released on [email protected] and https://app.relative-ci.com

@steverep
Copy link

@vio I'm getting a chance to play with this now. The results seem as expected when viewing the table by "size" and then clicking a module. However, when viewing the table by "duplicate size" or "total size", the results seem to get corrupted and are heavily inflated.

@vio
Copy link
Member Author

vio commented Aug 19, 2024

@steverep thank you for checking! I was able to replicate it, the current metric gets taken into consideration when computing duplicate and total.

@vio
Copy link
Member Author

vio commented Aug 20, 2024

Fix released on [email protected] and https://app.relative-ci.com.

@steverep
Copy link

Awesome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants