Support kustomize manager with github-releases datasource

[djmcgreal-cc]

What would you like Renovate to be able to do?

Kserve is an example of a project that publishes Kubernetes manifests through GitHub releases.

Could renovate extract from a URL like https://github.com/kserve/kserve/releases/download/v0.8.0/kserve-runtimes.yaml and assign it to the github-releases datasource?

If you have any ideas on how this should be implemented, please tell us here.

Having browsed the code (nicely laid out by the way!), it seems like a possibly simple change within

renovate/lib/modules/manager/kustomize/extract.ts

Line 19 in 24691ac

export function extractResource(base: string): PackageDependency | null {

and

renovate/lib/modules/manager/kustomize/index.ts

Line 12 in 24691ac

export const supportedDatasources = [

I'm answering "Maybe" to self-implementing because I don't yet know what tests and documentation might be affected.

Is this a feature you are interested in implementing yourself?

Maybe

[github-actions[bot]]

Hi there,

Get your issue fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction.

We may close the issue if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

[rarkins]

I think your idea sounds right, but we'd need a reproduction repo to be sure.

[djmcgreal-cc]

I was able to add the support I needed via the regex manager:

  "regexManagers": [
    {
      "fileMatch": "kustomization.yaml",
      "matchStrings": ["https:\/\/github\.com\/(?<depName>.*\/.*?)\/releases\/download\/(?<currentValue>.*?)\/"],
      "datasourceTemplate": "github-releases",
    },
    {
      "fileMatch": "kustomization.yaml",
      "matchStrings": ["https:\/\/raw.githubusercontent.com\/(?<depName>[^\/]*\/[^\/]*)\/(?<currentValue>.*?)\/"],
      "datasourceTemplate": "github-tags",
    }
  ]

That was easy, though an in-tree solution would still be preferable for better validation, etc! Thanks :)

[Ch4s3r]

Wanted to have a self updating argocd instance via gitops.
I used argocd-autopilot repo bootstrap --app https://raw.githubusercontent.com/argoproj/argo-cd/v2.14.0/manifests/install.yaml to get a versioned app link in bootstrap/argo-cd/kustomization.yaml like this:

apiVersion: kustomize.config.k8s.io/v1beta1
configMapGenerator:
- behavior: merge
  literals:
  - |
    repository.credentials=- passwordSecret:
        key: git_token
        name: autopilot-secret
      url: https://github.com/
      usernameSecret:
        key: git_username
        name: autopilot-secret
  name: argocd-cm
kind: Kustomization
namespace: argocd
resources:
- https://raw.githubusercontent.com/argoproj/argo-cd/v2.14.0/manifests/install.yaml

And this solution still works flawless today:

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": [
    "config:recommended"
  ],
  "customManagers": [
    {
      "customType": "regex",
      "description": "Update GitHub release references in kustomization.yaml",
      "fileMatch": ["kustomization.yaml"],
      "matchStrings": [
        "https:\\/\\/github\\.com\\/(?<depName>.*\\/.*?)\\/releases\\/download\\/(?<currentValue>.*?)\\/"
      ],
      "datasourceTemplate": "github-releases"
    },
    {
      "customType": "regex",
      "description": "Update GitHub tag references in kustomization.yaml",
      "fileMatch": ["kustomization.yaml"],
      "matchStrings": [
        "https:\\/\\/raw.githubusercontent.com\\/(?<depName>[^\\/]*\\/[^\\/]*)\\/(?<currentValue>.*?)\\/"
      ],
      "datasourceTemplate": "github-tags"
    }
  ]
}

This could be part of the kustomize manager or maybe a predefined config

[HonkingGoose]

@rarkins the user seems to have fixed their own problem with a regex manager workaround.

Do we still want to work on this issue? And if yes, do we still want a minimal reproduction?

[clementguillot]

@djmcgreal-cc I tried your configuration, and various modifications but none of them worked.

Has someone be able to make this thing work?

[loganmarchione]

@clementguillot - I have a similar setup and it's working fine for me.

This is my renovate.json, which resulted in this PR.

[clementguillot]

@loganmarchione thank you very much for sharing your config, I finally have openned PRs for K8s and ArgoCD dependencies!

Maybe it could help, I had the following mistakes in my config:

• I was using both kubernetes and kustomize managers at the same time. Now I only have kubernetes.
• I was extending the configuration with another repo using this:

"extends": [
    "local>myorg/renovate"
  ],

And I had to change for config:base.

• And finally, I updated the github-tags regex with back-slashed . in domain:

    {
      "fileMatch": ["manifests\/.+\/kustomization.ya?ml$"],
      "matchStrings": ["https:\/\/raw\.githubusercontent\.com\/(?<depName>[^\/]*\/[^\/]*)\/(?<currentValue>.*?)\/"],
      "datasourceTemplate": "github-tags",
    }

[viceice]

the dot needs double backslash to be properly JSON encoded