Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Prune tag duplicates #24

Open
admbeck opened this issue Aug 26, 2024 · 3 comments
Open

Bug: Prune tag duplicates #24

admbeck opened this issue Aug 26, 2024 · 3 comments
Labels
bug response required Requires a response from the user that opened the issue

Comments

@admbeck
Copy link

admbeck commented Aug 26, 2024

Is your feature request related to a problem? Please describe.
During manual tagging, tag duplicates may appear that I fail to notice at first or even second glance. These are not aliases, but literal duplicates, such as two instances of "original" or a specific eye color.

Describe the solution you'd like
I would like the application to automatically check for any duplicate tags during the tagging process. If duplicates are found, the system should prevent the user from saving the image until the duplicates are resolved. Ideally, the application would also highlight or point out which tags are duplicated, making it easier for the user to correct the issue.

Describe alternatives you've considered
Manual Checking: Manually reviewing tags to spot duplicates before saving. This is time-consuming and prone to human error.
Post-Tagging Review: Implementing a secondary review step where duplicates are flagged after saving. I even had to made a python script to prune duplicates, there were so many of them.

@resucutie
Copy link
Owner

Huh. In theory, those should've been grabbed by both the autofixer and the tag text field.

Can you show it in action with an image that will be added?

@resucutie resucutie added the response required Requires a response from the user that opened the issue label Sep 1, 2024
@admbeck
Copy link
Author

admbeck commented Sep 4, 2024

The issue exists on 1.5.2. I tested it with 1.6.0-pr and I am yet to encounter duplicates. This is screenshot on 1.5.2. "solo" tag is duplicated
image
image
Opening this image in 1.6.0-pr and saving it again removed duplicate tags for this image.

@resucutie
Copy link
Owner

Odd

Kooha-2024-10-01-19-06-53.mp4

@resucutie resucutie changed the title Feature Request: Prune tag duplicates Bug: Prune tag duplicates Oct 1, 2024
@resucutie resucutie added the bug label Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug response required Requires a response from the user that opened the issue
Projects
None yet
Development

No branches or pull requests

3 participants
@resucutie @admbeck and others