From 99dd4fbe99dd2eac814c80d382487b973ea7c26b Mon Sep 17 00:00:00 2001 From: return_request <128721050+returnrqt@users.noreply.github.com> Date: Thu, 16 Jan 2025 21:09:52 +0100 Subject: [PATCH 1/7] update differences --- README.md | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 08c80e05..4a5cb1e1 100644 --- a/README.md +++ b/README.md @@ -25,10 +25,12 @@ Found any bugs? Submit an [issue](https://github.com/returnrqt/bloxstrap/issues) ## Differences from Bloxstrap - Integrations - Player logs - Players leaving/joining server + - Message logs - Fast Flags - Flag profiles - Removed editor warnings & flag validation - - In-game menu editor + - Roblox menu customization + - More presets - Channels - Channel changer - Cancelling Roblox upgrades @@ -38,6 +40,9 @@ Found any bugs? Submit an [issue](https://github.com/returnrqt/bloxstrap/issues) - Multi-instance launching - Appearance - Customizable downloading status + - Extras + - Save last opened settings page + - Custom bootstrapper themes *More changes coming soon!* @@ -64,4 +69,4 @@ Found any bugs? Submit an [issue](https://github.com/returnrqt/bloxstrap/issues) [repo-releases]: https://github.com/returnrqt/bloxstrap/releases [repo-latest]: https://github.com/returnrqt/bloxstrap/releases/latest -[discord-invite]: https://discord.gg/xSsamjAU84 \ No newline at end of file +[discord-invite]: https://discord.gg/xSsamjAU84 From 61ccf471daba8df1e66cb2c55c9ec8bab07dedad Mon Sep 17 00:00:00 2001 From: GoingCrazyDude Date: Fri, 17 Jan 2025 17:35:23 +0530 Subject: [PATCH 2/7] warn that not all strings will be translated --- Bloxstrap/Resources/Strings.Designer.cs | 5 +- Bloxstrap/Resources/Strings.resx | 133 ++++++++++++------------ 2 files changed, 70 insertions(+), 68 deletions(-) diff --git a/Bloxstrap/Resources/Strings.Designer.cs b/Bloxstrap/Resources/Strings.Designer.cs index e37eefa2..6605641e 100644 --- a/Bloxstrap/Resources/Strings.Designer.cs +++ b/Bloxstrap/Resources/Strings.Designer.cs @@ -1233,7 +1233,8 @@ public static string Dialog_LanguageSelector_Header { } /// - /// Looks up a localized string similar to Choose a language before continuing with installation.. + /// Looks up a localized string similar to Choose a language before continuing with installation. + ///Some text might not be translated to preferred language.. /// public static string Dialog_LanguageSelector_Subtext { get { @@ -2213,7 +2214,7 @@ public static string Menu_Appearance_Icon_Title { } /// - /// Looks up a localized string similar to A relaunch is required for changes to take effect.. + /// Looks up a localized string similar to A relaunch is required for changes to take effect. Some text might not be translated to preferred language.. /// public static string Menu_Appearance_Language_Description { get { diff --git a/Bloxstrap/Resources/Strings.resx b/Bloxstrap/Resources/Strings.resx index 5a053122..913f67c2 100644 --- a/Bloxstrap/Resources/Strings.resx +++ b/Bloxstrap/Resources/Strings.resx @@ -823,13 +823,14 @@ Selecting 'No' will ignore this warning and continue installation. Choose preferred language - Choose a language before continuing with installation. + Choose a language before continuing with installation. +Some text might not be translated to preferred language. Language - A relaunch is required for changes to take effect. + A relaunch is required for changes to take effect. Some text might not be translated to preferred language. Allow use of unsupported Roblox languages @@ -1273,7 +1274,7 @@ Would you like to enable test mode? Channel - + Launch Roblox Studio @@ -1398,34 +1399,34 @@ Please close any applications that may be using Roblox's files, and relaunch. Framerate cap - + Chat translation - + Allows to disable VR mode toggle. - - + + Hides the button for submitting feedback on translation quality. - - + + Disables haptic feedback features, such as vibrations for controllers. - - + + Removes FPS presets from the menu. - - + + Allows players to disable interface translation. - - + + Disables automatic translation of chat messages. - - + + Flag state - - + + Show values of specified flags during runtime. Each flag is comma separated. - - + + Studio @@ -1440,13 +1441,13 @@ Please close any applications that may be using Roblox's files, and relaunch. Type - + User Id - + Username - + Time @@ -1458,48 +1459,48 @@ Please close any applications that may be using Roblox's files, and relaunch. Save and Launch - - Ping breakdown - - - Sends detailed ping information to the Roblox console. - - - Launching failed due to missing client. + + Ping breakdown + + + Sends detailed ping information to the Roblox console. + + + Launching failed due to missing client. Please enable Roblox upgrades. - - - Player logs - - - Message - - - Message logs - - - Displays recently sent messages by players. - - - Player and Message logs - - - Shows you players joining/leaving and messages being sent. + + + Player logs + + + Message + + + Message logs + + + Displays recently sent messages by players. + + + Player and Message logs + + + Shows you players joining/leaving and messages being sent. Only works with [text chat service](https://devforum.roblox.com/t/new-in-experience-text-chat-system-public-release/1848837). - - - Ansel support is required for shaders. - - - Thank you for using Bloxshade with Fishstrap - - - Ansel support has been enabled - - - Profiles - - - This channel is out of date, and is likely no longer being updated. Please use another channel. - + + + Ansel support is required for shaders. + + + Thank you for using Bloxshade with Fishstrap + + + Ansel support has been enabled + + + Profiles + + + This channel is out of date, and is likely no longer being updated. Please use another channel. + \ No newline at end of file From 6babfb8d2af0518ddc675df05c7cad62d28ce18a Mon Sep 17 00:00:00 2001 From: Naveandice <84022504+Naveandice@users.noreply.github.com> Date: Sat, 18 Jan 2025 19:23:32 +0300 Subject: [PATCH 3/7] ci: use download-artifact action --- .github/workflows/ci-release.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.github/workflows/ci-release.yml b/.github/workflows/ci-release.yml index d116ba8d..b3da8335 100644 --- a/.github/workflows/ci-release.yml +++ b/.github/workflows/ci-release.yml @@ -39,6 +39,12 @@ jobs: if: startsWith(github.ref, 'refs/tags/v') steps: + - name: Download artifact + uses: actions/download-artifact@v4 + with: + name: Bloxstrap (Release) (${{ github.sha }}) + path: release + - name: Rename binaries run: mv release/Bloxstrap.exe Bloxstrap-${{ github.ref_name }}.exe @@ -55,6 +61,12 @@ jobs: if: startsWith(github.ref, 'refs/tags/release-test') steps: + - name: Download artifact + uses: actions/download-artifact@v4 + with: + name: Bloxstrap (Release) (${{ github.sha }}) + path: release + - name: Rename binaries run: mv release/Bloxstrap.exe Bloxstrap-${{ github.ref_name }}.exe From 2b8fd7f8e6f2af9de511b119163920555b68a343 Mon Sep 17 00:00:00 2001 From: Naveandice <84022504+Naveandice@users.noreply.github.com> Date: Sat, 18 Jan 2025 19:40:55 +0300 Subject: [PATCH 4/7] ci: rename artifacts and binaries to Fishstrap --- .github/workflows/ci-debug.yml | 4 ++-- .github/workflows/ci-release.yml | 18 +++++++++--------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/ci-debug.yml b/.github/workflows/ci-debug.yml index 3c290ac4..a28f21e2 100644 --- a/.github/workflows/ci-debug.yml +++ b/.github/workflows/ci-debug.yml @@ -26,5 +26,5 @@ jobs: - name: Upload Artifact uses: actions/upload-artifact@v4 with: - name: Bloxstrap (Debug) (${{ github.sha }}) - path: .\Bloxstrap\bin\Debug\net6.0-windows\win-x64\publish\* \ No newline at end of file + name: Fishstrap (Debug) (${{ github.sha }}) + path: .\Bloxstrap\bin\Debug\net6.0-windows\win-x64\publish\* diff --git a/.github/workflows/ci-release.yml b/.github/workflows/ci-release.yml index b3da8335..7051adb4 100644 --- a/.github/workflows/ci-release.yml +++ b/.github/workflows/ci-release.yml @@ -30,7 +30,7 @@ jobs: id: upload-artifact uses: actions/upload-artifact@v4 with: - name: Bloxstrap (Release) (${{ github.sha }}) + name: Fishstrap (Release) (${{ github.sha }}) path: .\Bloxstrap\bin\Release\net6.0-windows\win-x64\publish\* release: @@ -42,18 +42,18 @@ jobs: - name: Download artifact uses: actions/download-artifact@v4 with: - name: Bloxstrap (Release) (${{ github.sha }}) + name: Fishstrap (Release) (${{ github.sha }}) path: release - name: Rename binaries - run: mv release/Bloxstrap.exe Bloxstrap-${{ github.ref_name }}.exe + run: mv release/Bloxstrap.exe Fishstrap-${{ github.ref_name }}.exe - name: Create release uses: softprops/action-gh-release@v2 with: draft: true - files: Bloxstrap-${{ github.ref_name }}.exe - name: Bloxstrap ${{ github.ref_name }} + files: Fishstrap-${{ github.ref_name }}.exe + name: Fishstrap ${{ github.ref_name }} release-test: needs: build @@ -64,15 +64,15 @@ jobs: - name: Download artifact uses: actions/download-artifact@v4 with: - name: Bloxstrap (Release) (${{ github.sha }}) + name: Fishstrap (Release) (${{ github.sha }}) path: release - name: Rename binaries - run: mv release/Bloxstrap.exe Bloxstrap-${{ github.ref_name }}.exe + run: mv release/Bloxstrap.exe Fishstrap-${{ github.ref_name }}.exe - name: Create release uses: softprops/action-gh-release@v2 with: draft: true - files: Bloxstrap-${{ github.ref_name }}.exe - name: Bloxstrap ${{ github.ref_name }} + files: Fishstrap-${{ github.ref_name }}.exe + name: Fishstrap ${{ github.ref_name }} From dd9dff5a0aa55082801c0d85d4c9169a25f9eb6a Mon Sep 17 00:00:00 2001 From: Naveandice <84022504+Naveandice@users.noreply.github.com> Date: Sat, 18 Jan 2025 19:44:53 +0300 Subject: [PATCH 5/7] ci: remove unused outputs --- .github/workflows/ci-release.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/ci-release.yml b/.github/workflows/ci-release.yml index 7051adb4..868adf76 100644 --- a/.github/workflows/ci-release.yml +++ b/.github/workflows/ci-release.yml @@ -5,9 +5,6 @@ jobs: build: runs-on: windows-latest - outputs: - artifact-id: ${{ steps.upload-artifact.outputs.artifact-id }} - steps: - uses: actions/checkout@v4 with: @@ -27,7 +24,6 @@ jobs: run: dotnet publish -p:PublishSingleFile=true -p:CommitHash=${{ github.sha }} -p:CommitRef=${{ github.ref_type }}/${{ github.ref_name }} -r win-x64 -c Release --self-contained false .\Bloxstrap\Bloxstrap.csproj - name: Upload Artifact - id: upload-artifact uses: actions/upload-artifact@v4 with: name: Fishstrap (Release) (${{ github.sha }}) From 1feb8c3fe60ec87aa9bcc02a26f9b79eb371a1f6 Mon Sep 17 00:00:00 2001 From: GoingCrazyDude Date: Sun, 19 Jan 2025 15:08:06 +0530 Subject: [PATCH 6/7] better deeplink --- Bloxstrap/Models/Entities/ActivityData.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Bloxstrap/Models/Entities/ActivityData.cs b/Bloxstrap/Models/Entities/ActivityData.cs index 5474b6bc..74aecfac 100644 --- a/Bloxstrap/Models/Entities/ActivityData.cs +++ b/Bloxstrap/Models/Entities/ActivityData.cs @@ -105,7 +105,7 @@ public string GameHistoryDescription public string GetInviteDeeplink(bool launchData = true) { - string deeplink = $"roblox://experiences/start?placeId={PlaceId}"; + string deeplink = $"https://www.roblox.com/experiences/start?placeId={PlaceId}"; if (ServerType == ServerType.Private) // thats not going to work deeplink += "&accessCode=" + AccessCode; From c92c5c001034ae71007353a1aac0f405b503b012 Mon Sep 17 00:00:00 2001 From: GoingCrazyDude Date: Sun, 19 Jan 2025 15:16:49 +0530 Subject: [PATCH 7/7] fix typo --- Bloxstrap/Models/Entities/ActivityData.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Bloxstrap/Models/Entities/ActivityData.cs b/Bloxstrap/Models/Entities/ActivityData.cs index 74aecfac..e0b6f48e 100644 --- a/Bloxstrap/Models/Entities/ActivityData.cs +++ b/Bloxstrap/Models/Entities/ActivityData.cs @@ -105,7 +105,7 @@ public string GameHistoryDescription public string GetInviteDeeplink(bool launchData = true) { - string deeplink = $"https://www.roblox.com/experiences/start?placeId={PlaceId}"; + string deeplink = $"https://www.roblox.com/games/start?placeId={PlaceId}"; if (ServerType == ServerType.Private) // thats not going to work deeplink += "&accessCode=" + AccessCode;