Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specify cache key when caching #680

Open
dexterorion opened this issue Feb 21, 2024 · 0 comments
Open

Allow specify cache key when caching #680

dexterorion opened this issue Feb 21, 2024 · 0 comments

Comments

@dexterorion
Copy link

Hey there. Hope everyone is well and safe.

We've been using reviewdog in our company, and it has been working really great.

But we are facing a challenge. We are using pull_request_target for our specific purpose, which leads to some concurrency problems when saving / restoring caches.

Because pull_request_target runs under base branch, when we have multiple PRs pointing to base branch, it causes some conflicts.

The way we see it might solve our specific problem is allowing us to control which is the cache key value, instead of using the generated one: https://github.com/reviewdog/action-golangci-lint/blob/master/src/cache.ts#L17

I am wondering if that is a desired feature for reviewdog action-golangci-lint.

If it is, I can test a solution within my company and provide further pull request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant