Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra empty line at the end of the exported file #49

Open
ksjewell opened this issue Oct 25, 2023 · 2 comments
Open

Extra empty line at the end of the exported file #49

ksjewell opened this issue Oct 25, 2023 · 2 comments
Assignees
@jorainer

Comments

@ksjewell
Copy link

ksjewell commented Oct 25, 2023 •
edited
Loading

When exporting MassBank records two empty lines are printed at the end of the file. This will evidently cause the validator at MassBank-Data to fail.

See Pull request 246 at MassBank-data
@jorainer
Copy link
Member

Thanks for reporting! I will look into it.

@jorainer jorainer self-assigned this Oct 27, 2023
jorainer added a commit that referenced this issue Oct 31, 2023
@jorainer
fix: skip additional empty line in MassBank export
c86c35d 
- Drop the extra empty line in MassBank exports (issue #49).
jorainer added a commit that referenced this issue Oct 31, 2023
@jorainer
fix: drop additional empty line in MassBank export (issue #49)
21cf023
jorainer added a commit that referenced this issue Oct 31, 2023
@jorainer
Merge pull request #50 from rformassspectrometry/jomain
2123b08 
Fix issue #49
@jorainer
Copy link
Member

Thanks for reporting @ksjewell !

I removed now the extra empty line at the end of an export. Changes have been pushed to Bioconductor (for release 3.18 and devel).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorainer jorainer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jorainer @ksjewell